Macros reset unreleased keys #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezanzeb
force-pushed
the
macro_reset
branch
from
c6c5771 to
5066d56
Compare
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a macro like
key_down(Shift_L)is used, and the injection stops, Shift would keep pressing down, rendering all attempts to interact with the system useless.When an injection is stopped, the macro handler will now reset all pressed keys. If the gui isn't open to stop an injection, unplugging the input device will cause those keys to be reset as well.
Previously, I added the
inputremapperpanicquitcodeword in #1007 to regain control of the system. But since this only works when a keyboard is the source device, it was not a good solution. I therefore decided to revert that.I also split test_macros up a bit more.
blocked by #1024