Improved test setup

[sezanzeb]

Applying a few things I learned in the past 2 years to input-remapper.

• Using patch.object instead of monkey-patches
• Moving stuff towards a dependency injection architecture, which allows better patches in tests. New classes, which might eventually be injected as dependencies:
  • PathUtils
  • UserUtils
  • Migrations
• Patching UInput class methods, instead of patching the UInput class as a whole
• Wrapped input-remapper-control in a class
• Moved static logging methods into logger class

With this, import order and patch order doesn't matter anymore

This allows:

• to make a decorator, that is applied to each test-class, to handily do the patches whenever we want them. To automatically and fully reset the patches after our tests, if we don't want them for whatever reason in other tests. And re-apply them arbitrarily later on. Using a decorator, because patches are commonly applied as a decorator already (@patch.object(...)) and it allows to do things without having to call super() in setUp and tearDown.
• to remove the old complicated test setup (which was, funnily, already a lot better than the older one)
• to more easily switch to pytest, if we want to.
• Tests didn't always work out-of-the-box in IDEs, now they do.
• using patch.object adds handy assertions that we can use on patched methods.

[sezanzeb]

@jonasBoss this is quite a lot to review I guess, sorry. This isn't urgent, but if you don't have time to spare any time soon I feel fine with just merging it. I'm not sure if there is anything important to look at, no features were added or bugs fixed, it's just refactoring and changes to tests.

The UserUtils and PathUtils classes are a bit funky, but eventually I hope it might turn into a neat dependency-injected architecture, for which this is the first step. They are just utils mostly, but they do use some variables that need to be different during tests, so there is a point in wrapping them in a class that can be patched, which is a bit more difficult if they are globals.

[sezanzeb]

There are lots of new TODO comments scattered about mentioning dependency injection.

A case-sensitive search for ^[a-z]\w+\s=\s[A-Z].+\( finds global things that should be injected instead.

[sezanzeb]

😂

[sezanzeb]

@jonasBoss are you currently available?

[jonasBoss]

yeah I currently have some free time.
Going to look at this tomorrow

[jonasBoss]

So this is mostly about moving all the standalone functions into classes?

I don't see any obvious issues!