Use || instead of ?? to catch empty strings as well

sgenoud · Jan 17, 2025 · f542d84 · f542d84
1 parent a1444e9
commit f542d84
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/packages/studio/src/builder.worker.js b/packages/studio/src/builder.worker.js
@@ -87,7 +87,7 @@ try {
   try {
     return runInContext(editedText, {});
   } catch (e) {
-    return {};
+    return null;
   }
 };
 

diff --git a/packages/studio/src/utils/downloadCode.js b/packages/studio/src/utils/downloadCode.js
@@ -3,8 +3,8 @@ import builderAPI from './builderAPI';
 
 export default async (code, fileName) => {
   fileName = fileName
-    ?? await builderAPI.extractDefaultNameFromCode(code)
-    ?? 'replicad-script'
+    || await builderAPI.extractDefaultNameFromCode(code)
+    || 'replicad-script'
   return fileSave(
     new Blob([code], {
       type: "application/javascript",

diff --git a/packages/studio/src/utils/saveShape.js b/packages/studio/src/utils/saveShape.js
@@ -19,9 +19,9 @@ export default async function saveShapes(shapeId, fileType = "stl", code) {
     const ext = mapExt(fileType);
 
     await fileSave(blob, {
-      fileName: `${name ?? defaultName ?? "shape"}.${ext}`,
+      fileName: `${name || defaultName || "shape"}.${ext}`,
       extensions: [`.${ext}`],
-      description: `Save ${name ?? defaultName ?? "shape"} as ${fileType}`,
+      description: `Save ${name || defaultName || "shape"} as ${fileType}`,
     });
     return;
   }
@@ -34,7 +34,7 @@ export default async function saveShapes(shapeId, fileType = "stl", code) {
   await fileSave(zipBlob, {
     id: "exports",
     description: "Save zip",
-    fileName: `${defaultName ?? shapeId}.zip`,
+    fileName: `${defaultName || shapeId}.zip`,
     extensions: [".zip"],
   });
 }