recompiler: fixed fragment shader built-in attribute access #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When I first started the game, it crashed without errors, immediately after the character appeared on the location, but then it loaded normally, I managed to run a little. Although the performance of the game seemed to deteriorate (I did not immediately turn on the fps counter, but later I saw 25-28 frames in places). |
|
It is a subtle difference, but it is there. i.e. lets have a look at some grass on the ground. main: PR: A closer look at the same grass: main: PR: I was not able to see any performance changes. Very good job |
diegolix29
pushed a commit
to diegolix29/shadPS4
that referenced
this pull request
Dec 7, 2024
…emu#1676) * recompiler: fixed fragment shader built-in attribute access * handle en/addr separately * handle other registers as well
diegolix29
pushed a commit
to diegolix29/shadPS4
that referenced
this pull request
Dec 7, 2024
…emu#1676) * recompiler: fixed fragment shader built-in attribute access * handle en/addr separately * handle other registers as well
diegolix29
pushed a commit
to diegolix29/shadPS4
that referenced
this pull request
Dec 8, 2024
…emu#1676) * recompiler: fixed fragment shader built-in attribute access * handle en/addr separately * handle other registers as well
diegolix29
pushed a commit
to diegolix29/shadPS4
that referenced
this pull request
Dec 9, 2024
…emu#1676) * recompiler: fixed fragment shader built-in attribute access * handle en/addr separately * handle other registers as well
lucashartmann
added a commit
to lucashartmann/shadPS4
that referenced
this pull request
Dec 9, 2024
…hadps4-emu#1676)" This reverts commit 8eacb88.
Xcedf
pushed a commit
to Xcedf/shadPS4
that referenced
this pull request
Dec 10, 2024
…emu#1676) * recompiler: fixed fragment shader built-in attribute access * handle en/addr separately * handle other registers as well
Xcedf
pushed a commit
to Xcedf/shadPS4
that referenced
this pull request
Dec 10, 2024
…emu#1676) * recompiler: fixed fragment shader built-in attribute access * handle en/addr separately * handle other registers as well
Xcedf
pushed a commit
to Xcedf/shadPS4
that referenced
this pull request
Dec 28, 2024
…emu#1676) * recompiler: fixed fragment shader built-in attribute access * handle en/addr separately * handle other registers as well
Xcedf
pushed a commit
to Xcedf/shadPS4
that referenced
this pull request
Dec 28, 2024
…emu#1676) * recompiler: fixed fragment shader built-in attribute access * handle en/addr separately * handle other registers as well
Xcedf
added a commit
to Xcedf/shadPS4
that referenced
this pull request
Dec 31, 2024
…hadps4-emu#1676)" This reverts commit 8eacb88. Revert "semaphore: Add GCD semaphore implementation. (shadps4-emu#1677)" This reverts commit e1ecfb8. Revert "hot-fix: Silence depth macrotiled warning" This reverts commit 357b782. Revert "buffer_cache: Bump usable address space to 40bits" This reverts commit 6acfdd5.
Xcedf
added a commit
to Xcedf/shadPS4
that referenced
this pull request
Dec 31, 2024
…hadps4-emu#1676)" This reverts commit 8eacb88.
Xcedf
added a commit
to Xcedf/shadPS4
that referenced
this pull request
Dec 31, 2024
…hadps4-emu#1676)" This reverts commit 8eacb88. Revert "semaphore: Add GCD semaphore implementation. (shadps4-emu#1677)" This reverts commit e1ecfb8.
Xcedf
added a commit
to Xcedf/shadPS4
that referenced
this pull request
Dec 31, 2024
…hadps4-emu#1676)" This reverts commit 8eacb88.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registers contain enable flags for built-in attributes that should be checked when recompiling in order to access the correct built-in.
Fixes inverted normals issue in BB that caused some artifacts on grass and mirrored objects (like dog fur).