Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle MEM_SEMAPHORE PM4 packets #1815

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mikusp
Copy link
Contributor

@mikusp mikusp commented Dec 18, 2024

Implements MEM_SEMAPHORE as a global barrier in the pipeline, that is probably not optimal from the performance perspective, but allows games to process further.

If you have any comments let me know and I'll try to fix

@Missake212
Copy link

Missake212 commented Jan 2, 2025

Makes Ratchet & Clank boot on Linux, didn't try on Windows, a rebase would be nice I believe

@Graubek
Copy link

Graubek commented Jan 2, 2025

On windows Ratchet & Clank also boots

@DanielSvoboda
Copy link
Contributor

DanielSvoboda commented Jan 4, 2025

Name:ŌKAMI HD | Serial:CUSA08364 | Version:01.00 | Size:16.8 GB
The emulator stops due to lack of MEM_SEMAPHORE, now with this PR it presents this error, must not be related to it:

[Render.Vulkan] vk_platform.cpp:DebugUtilsCallback:63: VUID-VkShaderModuleCreateInfo-pCode-08737: Validation Error: [ VUID-VkShaderModuleCreateInfo-pCode-08737 ] | MessageID = 0xa5625282 | vkCreateShaderModule(): pCreateInfo->pCode (spirv-val produced an error):
Sampling operation is invalid for multisample image
%64 = OpImageSampleImplicitLod %f32vec4_id %63 %60 None
. The Vulkan spec states: If pCode is a pointer to SPIR-V code, pCode must adhere to the validation rules described by the Validation Rules within a Module section of the SPIR-V Environment appendix (https://vulkan.lunarg.com/doc/view/1.3.283.0/windows/1.3-extensions/vkspec.html#VUID-VkShaderModuleCreateInfo-pCode-08737)

LOG: shad_log.txt

image

@polybiusproxy
Copy link
Collaborator

It's issue you're having is not related to the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants