Improved error handling in sceKernelAllocateDirectMemory #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of our existing cases are normally EAGAIN returns.
StevenMiller123
changed the title
|
Pretty sure we already tested this on Discord but since these commits are more recent I thought I'd give them a try and send the logs here. NBA2K15 NBA2K17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some games, most notably the Call of Duty series of games, intentionally make
sceKernelAllocateDirectMemorycalls that fail. To match hardware behavior, we should returnORBIS_KERNEL_ERROR_EAGAINinstead of throwing an assert.This should fix games that still hit
Unable to find free direct memory areaasserts after #1896.Credits to @red-prig and @raphaelthegreat for helping with the error cases.
This needs testing, as it could hide deeper issues in some games.