Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect error code in equeue #2093

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kalaposfos13
Copy link
Contributor

According to the system library, the out parameter being null should not warrant returning an error code. This fixes LBP3's input handling (and probably games with a similar issue), as it was stuck in a loop due to it thinking the function timed out because of this.

@StevenMiller123
Copy link
Contributor

Unsurprisingly, this breaks The Last of Us Remastered. The game uses equeues to check for trophies, using a while loop that loops until sceKernelWaitEqueue returns an error.
I think you should take a closer look at the current implementation for this function, as it seems like you've misunderstood the purpose of that ETIMEDOUT return. It's there to properly handle cases where no events are triggered during the wait.
shad_log.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants