Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HLS): Fix subtitle timing when no discontinuity but there is X-TIMESTAMP-MAP #7681

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Nov 27, 2024

Fixes #7673

@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format component: captions/subtitles The issue involves captions or subtitles priority: P1 Big impact or workaround impractical; resolve before feature release labels Nov 27, 2024
@avelad avelad added this to the v4.13 milestone Nov 27, 2024
@avelad avelad added priority: P2 Smaller impact or easy workaround and removed priority: P1 Big impact or workaround impractical; resolve before feature release labels Nov 27, 2024
@avelad avelad merged commit 7afe08e into shaka-project:main Nov 27, 2024
23 of 24 checks passed
@avelad avelad deleted the hls-subs branch November 27, 2024 13:14
@markuswolters
Copy link

markuswolters commented Nov 27, 2024

Thanks @avelad for the quick fix. I'm wondering if that's another bug, at least with the 4.12.1/4.11.13 versions: When subtitles are turned on and I do a fast skip while video is buffering (e.g. video is playing, then I skip +30seconds, video goes into buffering mode, then - while still in buffering - I do another skip +30s), 50% chances are that subtitles are not being displayed anymore until stream gets reloaded completly. When I delay the next skip until buffering has finished, everything is fine. Does this hint you to something?

I do see these debug outputs during skips while video buffering:

shaka-player.ui.debug.js:151 (audio:12) clear: currently updating
shaka-player.ui.debug.js:151 (audio:12) Aborting operation due to seek
shaka-player.ui.debug.js:151 (video:26) clear: currently updating
shaka-player.ui.debug.js:151 (video:26) Aborting operation due to seek
shaka-player.ui.debug.js:151 (text:30) clear: currently updating
shaka-player.ui.debug.js:151 (text:30) Aborting operation due to seek

@avelad
Copy link
Member Author

avelad commented Nov 27, 2024

I can't reproduce that in the main branch...

@markuswolters
Copy link

Thanks, I will verify with the main branch.

avelad added a commit that referenced this pull request Nov 27, 2024
avelad added a commit that referenced this pull request Nov 27, 2024
joeyparrish pushed a commit that referenced this pull request Dec 11, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 26, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: captions/subtitles The issue involves captions or subtitles component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.12.2/4.11.14 introduces subtitles with HLS streams being out of sync
4 participants