Fix name of BAT_THEME_{DARK,LIGHT} env vars #3168
Merged
+43
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably we should add a changelog entry, in case we want to push a bugfix release for it? 🙂 |
|
Would it be worth trying to add an integration test to prove these env vars work as expected or not really possible? |
bash
force-pushed
the
fix-env-var-names
branch
from
612839d to
8a11a46
Compare
|
Added a changelog entry and integration tests. TIL about |
keith-hall
approved these changes
Jan 9, 2025
|
Nice, thanks! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a bit embarrassing since I'm the person who wrote the code in the first place 😆