AlertDialogのUI実装 #19
Open
AlertDialogのUI実装 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
このコードってどこかで使用される予定とか将来的にあったりする？
There was a problem hiding this comment.
Figmaにはまだ書いてないけどログアウトとか権限周りで使うよ
lib/debug/debug_page.dart
Outdated
| _button( | ||
| 'Alert Dialog', | ||
| onPressed: () { | ||
| Navigator.of(context).push( |
There was a problem hiding this comment.
pushだけUtilのメソッドに変更して欲しい🙏
lib/util/navigator_util.dart
Outdated
| import 'package:pg_mobile/widgets/common_cupertino_alert_dialog.dart'; | ||
| import 'package:pg_mobile/widgets/common_material_alert_dialog.dart'; | ||
|
|
||
| class NavigatorUtil { |
There was a problem hiding this comment.
この名前だとrooting系の処理まとまってるクラスなのかなーって思ってしまうから
OSでモーダルの処理を分けてる旨が伝わる命名がベターだと思った
PlatformModalHandlerとかOSModalDispatcherとか
There was a problem hiding this comment.
確かにそうやね…
クラス名をPlatformModalHandlerに変更するね
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
Alert DialogのUIコンポーネントとその表示を行うメソッドを実装しました。
Alert DialogのデザインをなるべくFlutter標準のものに近づけるため、UI実装したものをデザインに逆輸入する予定です。
UI（Android）
UI（iOS）