Update CDA, guard ext-simplexml (#132)

shipmonk-rnd · Dec 30, 2024 · a609311 · a609311
1 parent ba0e2fc
commit a609311
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 17 deletions.
diff --git a/composer-dependency-analyser.php b/composer-dependency-analyser.php
@@ -10,4 +10,5 @@
 
 return (new Configuration())
     ->ignoreErrorsOnPath(__DIR__ . '/src/Provider', [ErrorType::DEV_DEPENDENCY_IN_PROD]) // providers are designed that way
+    ->ignoreErrorsOnExtensionAndPath('ext-simplexml', __DIR__ . '/src/Provider/SymfonyUsageProvider.php', [ErrorType::SHADOW_DEPENDENCY]) // guarded with extension_loaded()
     ->addPathToExclude(__DIR__ . '/tests/Rule/data');
diff --git a/composer.json b/composer.json
@@ -27,7 +27,7 @@
         "phpstan/phpstan-strict-rules": "^2.0.0",
         "phpstan/phpstan-symfony": "^2.0.0",
         "phpunit/phpunit": "^9.6.21",
-        "shipmonk/composer-dependency-analyser": "^1.6",
+        "shipmonk/composer-dependency-analyser": "^1.8.1",
         "shipmonk/name-collision-detector": "^2.0.0",
         "shipmonk/phpstan-rules": "^4.0.0",
         "slevomat/coding-standard": "^8.15.0",

diff --git a/composer.lock b/composer.lock
diff --git a/src/Provider/SymfonyUsageProvider.php b/src/Provider/SymfonyUsageProvider.php
@@ -32,6 +32,7 @@
 use function array_keys;
 use function count;
 use function explode;
+use function extension_loaded;
 use function file_get_contents;
 use function in_array;
 use function is_dir;
@@ -233,6 +234,10 @@ protected function fillDicClasses(string $containerXmlPath): void
             throw new LogicException(sprintf('Container %s does not exist', $containerXmlPath));
         }
 
+        if (!extension_loaded('simplexml')) { // should never happen as phpstan-doctrine requires that
+            throw new LogicException('Extension simplexml is required to parse DIC xml');
+        }
+
         $xml = @simplexml_load_string($fileContents);
 
         if ($xml === false) {