-
-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tape Recorder Housekeeping #3506
Tape Recorder Housekeeping #3506
Conversation
ports #55881, #51653, and #55908 from tgstation. adds wires to recorders
fixed ur pr body for u |
update this pr in case its missing something before i merge it tommorow at 3am |
Merge it tomorrow at 3am NOW |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could still use screwdriver act instead of having it in attackby! its kinda important so things can acctually trust COMSIG_ATOM_SCREWDRIVER_ACT.
donezo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything seems to be in order.
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request ports tgstation/tgstation#51653 tgstation/tgstation#55881 tgstation/tgstation#55908 from tgstation. adds wires to recorders <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game Tape recorders r cool. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: Erika - porting from /tg/ mostly. add: Tape Recorders now have a radial menu when used add: Tape recorders now make noises add: Tape recorders now have wires (can be remotely used) /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: Erika Fox <94164348+Bjarl@users.noreply.github.com> Co-authored-by: Sun-Soaked <45698967+Sun-Soaked@users.noreply.github.com>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request ports tgstation/tgstation#51653 tgstation/tgstation#55881 tgstation/tgstation#55908 from tgstation. adds wires to recorders <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game Tape recorders r cool. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: Erika - porting from /tg/ mostly. add: Tape Recorders now have a radial menu when used add: Tape recorders now make noises add: Tape recorders now have wires (can be remotely used) /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: Erika Fox <94164348+Bjarl@users.noreply.github.com> Co-authored-by: Sun-Soaked <45698967+Sun-Soaked@users.noreply.github.com>
About The Pull Request
ports
tgstation/tgstation#51653
tgstation/tgstation#55881
tgstation/tgstation#55908
from tgstation. adds wires to recorders
Why It's Good For The Game
Tape recorders r cool.
Changelog
🆑 Erika - porting from /tg/ mostly.
add: Tape Recorders now have a radial menu when used
add: Tape recorders now make noises
add: Tape recorders now have wires (can be remotely used)
/:cl: