Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tape Recorder Housekeeping #3506

Merged
merged 3 commits into from
Oct 26, 2024

Conversation

Erikafox
Copy link
Contributor

@Erikafox Erikafox commented Oct 9, 2024

About The Pull Request

ports
tgstation/tgstation#51653
tgstation/tgstation#55881
tgstation/tgstation#55908
from tgstation. adds wires to recorders

Why It's Good For The Game

Tape recorders r cool.

Changelog

🆑 Erika - porting from /tg/ mostly.
add: Tape Recorders now have a radial menu when used
add: Tape recorders now make noises
add: Tape recorders now have wires (can be remotely used)
/:cl:

ports #55881, #51653, and #55908 from tgstation. adds wires to recorders
@Erikafox Erikafox requested a review from a team as a code owner October 9, 2024 03:07
@github-actions github-actions bot added Sprites A bikeshed full of soulless bikes. Sound USSR Anthem 2.66 MB file. Code change Watch something violently break. labels Oct 9, 2024
@thgvr
Copy link
Member

thgvr commented Oct 10, 2024

fixed ur pr body for u

@rye-rice
Copy link
Member

update this pr in case its missing something before i merge it tommorow at 3am

@generalthrax
Copy link
Contributor

Merge it tomorrow at 3am NOW

Copy link
Member

@FalloutFalcon FalloutFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could still use screwdriver act instead of having it in attackby! its kinda important so things can acctually trust COMSIG_ATOM_SCREWDRIVER_ACT.

@Erikafox
Copy link
Contributor Author

It could still use screwdriver act instead of having it in attackby! its kinda important so things can acctually trust COMSIG_ATOM_SCREWDRIVER_ACT.

donezo

Copy link
Member

@Sun-Soaked Sun-Soaked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything seems to be in order.

@Sun-Soaked Sun-Soaked added this pull request to the merge queue Oct 26, 2024
Merged via the queue into shiptest-ss13:master with commit 2f3e092 Oct 26, 2024
16 checks passed
zimon9 pushed a commit to zimon9/Shiptest-PR-testing that referenced this pull request Oct 29, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
ports
tgstation/tgstation#51653
tgstation/tgstation#55881
tgstation/tgstation#55908
from tgstation. adds wires to recorders
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game

Tape recorders r cool.

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl: Erika - porting from /tg/ mostly.
add: Tape Recorders now have a radial menu when used
add: Tape recorders now make noises
add: Tape recorders now have wires (can be remotely used) 
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Co-authored-by: Erika Fox <94164348+Bjarl@users.noreply.github.com>
Co-authored-by: Sun-Soaked <45698967+Sun-Soaked@users.noreply.github.com>
zimon9 pushed a commit to zimon9/Shiptest-PR-testing that referenced this pull request Oct 29, 2024
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this pull request Dec 27, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
ports
tgstation/tgstation#51653
tgstation/tgstation#55881
tgstation/tgstation#55908
from tgstation. adds wires to recorders
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game

Tape recorders r cool.

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl: Erika - porting from /tg/ mostly.
add: Tape Recorders now have a radial menu when used
add: Tape recorders now make noises
add: Tape recorders now have wires (can be remotely used) 
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Co-authored-by: Erika Fox <94164348+Bjarl@users.noreply.github.com>
Co-authored-by: Sun-Soaked <45698967+Sun-Soaked@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Sound USSR Anthem 2.66 MB file. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants