Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move README to v1beta1 #1535

Merged

Conversation

qu1queee
Copy link
Contributor

Changes

Move README to v1beta1
Move CRs to use v1beta1 as the apiVersion and adjust the objects definition.

Fixes #1502

-->

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

Move CRs to use v1beta1 as the apiVersion
and adjust the objects definition

Signed-off-by: Adarsh Jaiswal <its.adarshjaiss@gmail.com>
@qu1queee qu1queee added the kind/documentation Categorizes issue or PR as related to documentation. label Mar 11, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 11, 2024
@openshift-ci openshift-ci bot added release-note-none Label for when a PR does not need a release note do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 11, 2024
@qu1queee qu1queee marked this pull request as ready for review March 11, 2024 14:48
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2024
@openshift-ci openshift-ci bot requested review from HeavyWombat and otaviof March 11, 2024 14:48
@qu1queee qu1queee requested review from SaschaSchwarze0 and removed request for otaviof March 13, 2024 07:14
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2024
Copy link
Contributor

openshift-ci bot commented Mar 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2024
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.13.0 milestone Mar 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ea6f69a into shipwright-io:main Mar 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEATURE] Move Readme Try It Section to BETA
3 participants