Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to newer Node version that is still supported by Paketo #1645

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions test/e2e/v1alpha1/common_suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,14 @@ func (b *buildPrototype) Dockerfile(dockerfile string) *buildPrototype {
return b
}

func (b *buildPrototype) Env(key string, value string) *buildPrototype {
b.build.Spec.Env = append(b.build.Spec.Env, core.EnvVar{
Name: key,
Value: value,
})
return b
}

func (b *buildPrototype) determineParameterIndex(name string) int {
index := -1
for i, paramValue := range b.build.Spec.ParamValues {
Expand Down
1 change: 1 addition & 0 deletions test/e2e/v1alpha1/e2e_image_mutate_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ var _ = Describe("For a Kubernetes cluster with Tekton and build installed", fun
OutputImageCredentials(os.Getenv(EnvVarImageRepoSecret)).
OutputImageInsecure(insecure).
OutputTimestamp(outputTimestamp).
Env("BP_NODE_VERSION", "~20").
BuildSpec()).
MustCreate()
}
Expand Down
8 changes: 8 additions & 0 deletions test/e2e/v1beta1/common_suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,14 @@ func (b *buildPrototype) OutputImage(image string) *buildPrototype {
return b
}

func (b *buildPrototype) Env(key string, value string) *buildPrototype {
b.build.Spec.Env = append(b.build.Spec.Env, core.EnvVar{
Name: key,
Value: value,
})
return b
}

func (b *buildPrototype) OutputVulnerabilitySettings(settings buildv1beta1.VulnerabilityScanOptions) *buildPrototype {
b.build.Spec.Output.VulnerabilityScan = &settings
return b
Expand Down
1 change: 1 addition & 0 deletions test/e2e/v1beta1/e2e_image_mutate_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ var _ = Describe("For a Kubernetes cluster with Tekton and build installed", fun
OutputImageCredentials(os.Getenv(EnvVarImageRepoSecret)).
OutputImageInsecure(insecure).
OutputTimestamp(outputTimestamp).
Env("BP_NODE_VERSION", "~20").
BuildSpec()).
MustCreate()
}
Expand Down