Fix flaky test case #1701
Merged
Fix flaky test case #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaschaSchwarze0
added
the
kind/flake
openshift-ci
bot
added
the
release-note-none
pull-request-size
bot
added
the
size/M
4 tasks
SaschaSchwarze0
force-pushed
the
sascha-fix-flaky-test
branch
from
d6dc013 to
1f532d8
Compare
Signed-off-by: Sascha Schwarze <schwarzs@de.ibm.com>
SaschaSchwarze0
force-pushed
the
sascha-fix-flaky-test
branch
from
1f532d8 to
99f5fe3
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HeavyWombat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixing a flaxy test case here.
The two tests basically set up a a Build with retention atBuildDeletion=true. They then created a BuildRun. Then they either changed the flag to false or removed the whole retention section. And now a race started because they immediatly deleted the Build. At that point in time, it is unclear if the owner reference had already been removed from the buildrun or not. When the test failed, it was not yet removed so that the BuildRun was unexpectetly deleted.
I am changing the test case to first check that the owner reference is removed before deleting the build.
Submitter Checklist
Release Notes