Fix gocritic findings
#292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeavyWombat
added
the
kind/cleanup
pull-request-size
bot
added
the
size/S
HeavyWombat
commented
Dec 16, 2024
| @@ -110,8 +110,7 @@ func (c *LogsCommand) Run(params *params.Params, ioStreams *genericclioptions.IO | |||
| fmt.Fprintf(ioStreams.Out, "Obtaining logs for BuildRun %q\n\n", c.name) | |||
|
|
|||
| var b strings.Builder | |||
| containers := append(pod.Spec.InitContainers, pod.Spec.Containers...) | |||
| for _, container := range containers { | |||
| for _, container := range append(pod.Spec.InitContainers, pod.Spec.Containers...) { | |||
There was a problem hiding this comment.
./pkg/shp/cmd/buildrun/logs.go:113:17: appendAssign: append result not assigned to the same slice
There was a problem hiding this comment.
never saw such range with append on the same line, nice.
HeavyWombat
commented
Dec 16, 2024
| @@ -107,8 +107,7 @@ func (f *Follower) Log(msg string) { | |||
| // tailLogs start tailing logs for each container name in init-containers and containers, if not | |||
| // started already. | |||
| func (f *Follower) tailLogs(pod *corev1.Pod) { | |||
| containers := append(pod.Spec.InitContainers, pod.Spec.Containers...) | |||
| for _, container := range containers { | |||
| for _, container := range append(pod.Spec.InitContainers, pod.Spec.Containers...) { | |||
There was a problem hiding this comment.
./pkg/shp/cmd/follower/follow.go:110:16: appendAssign: append result not assigned to the same slice
HeavyWombat
commented
Dec 16, 2024
| @@ -94,8 +94,6 @@ func (p *PodWatcher) WithNoPodEventsYetFn(fn NoPodEventsYetFn) *PodWatcher { | |||
|
|
|||
| // handleEvent applies user informed functions against informed pod and event. | |||
| func (p *PodWatcher) handleEvent(pod *corev1.Pod, event watch.Event) error { | |||
| //p.stopLock.Lock() | |||
| //defer p.stopLock.Unlock() | |||
There was a problem hiding this comment.
Probably unused by now.
HeavyWombat
commented
Dec 16, 2024
| @@ -18,7 +18,7 @@ func (wc *writeCounter) Write(p []byte) (int, error) { | |||
| } | |||
|
|
|||
| func trimPrefix(prefix, fpath string) string { | |||
| return strings.TrimPrefix(strings.Replace(fpath, prefix, "", -1), string(filepath.Separator)) | |||
| return strings.TrimPrefix(strings.ReplaceAll(fpath, prefix, ""), string(filepath.Separator)) | |||
There was a problem hiding this comment.
./pkg/shp/streamer/util.go:21:28: wrapperFunc: use strings.ReplaceAll method in `strings.Replace(fpath, prefix, "", -1)`
SaschaSchwarze0
requested changes
Dec 24, 2024
Resolve `gocritic` findings. Signed-off-by: Matthias Diester <matthias.diester@de.ibm.com>
Remove trailing whitespaces. Signed-off-by: Matthias Diester <matthias.diester@de.ibm.com>
HeavyWombat
force-pushed
the
fix/go-critic-findings
branch
from
d942093 to
514deb4
Compare
Add `gocritic` to the list of default linters. Signed-off-by: Matthias Diester <matthias.diester@de.ibm.com>
HeavyWombat
force-pushed
the
fix/go-critic-findings
branch
from
514deb4 to
32b23a6
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
While working on #291, I realized that my linter returned some minor findings in this repository.
Fix minor TYPO in
hack/verify-docs.sh.Resolve
gocriticfindings.Remove trailing whitespaces.
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes