Skip to content

Commit

Permalink
clean up jsdom
Browse files Browse the repository at this point in the history
  • Loading branch information
cesine committed Nov 27, 2024
1 parent 116a6a9 commit c57e5ef
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 11 deletions.
10 changes: 1 addition & 9 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ CSS_MIN=$(NODE_MODULES)/.bin/cleancss
JS_MIN=$(NODE_MODULES)/.bin/uglifyjs
JS_HINT=$(NODE_MODULES)/.bin/jshint
D3=$(NODE_MODULES)/d3
JSDOM=$(NODE_MODULES)/jsdom
NODEUNIT=$(NODE_MODULES)/nodeunit

CSS_FILES=\
src/css/detail.css\
Expand Down Expand Up @@ -61,7 +59,7 @@ build: rickshaw.min.css rickshaw.min.js
clean:
rm -rf rickshaw.css rickshaw.js rickshaw.min.*

test: $(D3) $(JSDOM) $(NODEUNIT)
test: $(D3)
npm test

$(JS_HINT):
Expand All @@ -76,12 +74,6 @@ $(JS_MIN):
$(D3):
npm install d3

$(JSDOM):
npm install jsdom

$(NODEUNIT):
npm install nodeunit

rickshaw.css: $(CSS_FILES)
cat $(CSS_FILES) > rickshaw.css

Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ Rickshaw relies on the fantastic [D3 visualization library](http://mbostock.gith

Some extensions require [jQuery](http://jquery.com) and [jQuery UI](http://jqueryui.com), but for drawing some basic graphs you'll be okay without.

Rickshaw uses [jsdom](https://github.com/tmpvar/jsdom) to run unit tests in Node to be able to do SVG manipulation. As of the jsdom 7.0.0 release, jsdom requires Node.js 4 or newer [jsdom changelog](https://github.com/tmpvar/jsdom/blob/master/Changelog.md#700). If you want to run the tests on your machine, and you don't have access to a version of node >= 4.0, you can `npm install jsdom@3` so that you can run the tests using the [3.x branch of jsdom](https://github.com/tmpvar/jsdom/tree/3.x).

## Rickshaw.Graph

Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
"jest": "^29.7.0",
"jest-environment-jsdom": "^29.7.0",
"jquery": "^3.2.1",
"jsdom": "^8.1.0",
"jshint": "^2.9.5",
"nodemon": "^1.11.0",
"uglify-js": "^2.8.29"
Expand Down

0 comments on commit c57e5ef

Please sign in to comment.