added manual flip state storage feature to retain the last selected o…

[Carlo579]

This is a feature enhancement for storing and managing the manual flip selection state and making the toggle rotation on/off functionality more seamless/intuitive.

High Level Use Cases Supported by This Enhancement:

1. On first launch it will load the default value of the last orientation flipped to from settings and will be the default from the schema XML
2. When the quick setting button is pushed it will used the last orientation pulled from settings
3. The quick setting button menu will show the last orientation as checked letting the user know what orientation will be enabled by the button
4. When the user selects a quick setting button menu item, it will switch to that orientation, store the orientation for the next toggle on/off cycle, and store the last orientation in settings to maintain the state selection across restarts.

Note: all of the above assumes the manual flip quick settings button is enabled in preferences to start

[shyzus]

Hi @Carlo579 thanks for sending in your pull request.

In regards to the proposed enhancement I can see the benefit it may offer to some users. Would like to see this enhancement merged. However from my brief testing with the changes in this pull request, it seems to break one thing and degrade the experience for another set of users being the mobile/tablet users.

When using the extension with these changes the rotate quicktoggle no longer defaults to switching between landscape and portrait. This is something people with a mobile/tablet that use this extension prefer to quickly and effectively switch between orientations.

With these changes it defaults to the last stored orientation it was set to. This also results in the button itself becoming useless if you use the drop down menu to switch to landscape and then click on the rotate button again.

I believe this enhancement may best be implemented with the addition of a single toggle in the extension preferences that changes the default behaviour of the rotate quicktoggle. From what mobile/tablet users expect to using the last stored orientation.

This still leaves the issue of the rotate quicktoggle becoming useless if the last stored orientation and the current orientation are the exact same.

I look forward to future changes you make to this pull request.