Store execution payloads during backfill if --prune-payloads false

[michaelsproul]

Description

@KolbyML notes that the ability to keep execution payloads during block backfill would be useful for syncing Trin (portal network client). It's a bit of a gotcha that at the moment Lighthouse throws out execution payloads during backfill sync, even when running with --prune-payloads false. We download the payloads from peers, and then throw them straight in the bin!

lighthouse/beacon_node/beacon_chain/src/historical_blocks.rs

Lines 121 to 134 in 2e0eb6d

	// Store block in the hot database without payload.
	self.store
	.blinded_block_as_kv_store_ops(&block_root, &blinded_block, &mut hot_batch);
	// Store the blobs too
	if let Some(blobs) = maybe_blobs {
	new_oldest_blob_slot = Some(block.slot());
	self.store
	.blobs_as_kv_store_ops(&block_root, blobs, &mut blob_batch);
	}
	// Store block roots, including at all skip slots in the freezer DB.
	for slot in (block.slot().as_usize()..prev_block_slot.as_usize()).rev() {
	chunk_writer.set(slot, block_root, &mut cold_batch)?;
	}

Steps to resolve

If prune-payloads is false, store execution payloads in the hot DB as part of import_historical_block_batch.

Additional Info

Should probably be implemented after the hdiff PR is merged, which modifies the backfill logic:

• Hierarchical state diffs #5978

[KolbyML]

Just to clarify some terminology as we (EF Portal) use a lot of confusing terminology.

• Portal: is a collection of p2p protocols built on the Portal-wire-specification which is a framework for building distributed storage networks or p2p networks in general
• Trin: is an implementation of the Portal specification and all the sub-protocols (history,state,beacon,etc). All networks are optional to implement.
• Trin Execution: is an Execution client we are implementing comparable to Geth/Nethermind/Besu/etc but with the key difference of we will not be using devp2p. So instead we will need to rely on “The Portal Networks”, archival formats, and Consensus clients to achieve what devp2p provides.

Our initial usecase of Trin Execution will be gossiping genesis-latest execution state diffs to the “Portal State Network”, but it will likely become a full Execution client released to the public in time. It also serves as a backup solution if we don’t get adequate adoption by major EL clients.

So this change would be very nice for syncing Trin Execution!

[michaelsproul]

Unblocked, will try to get this in for the next release

[chong-he]

I would like to give this a go

[michaelsproul]

Part of the changes required for this feature (pruning) are in this PR:

• Use oldest_block_slot to break off pruning payloads #6745

That PR updates the pruning to go back to the oldest_block_slot (rather than the slot of the downloaded checkpoint), which ensures that we will prune payloads between oldest_block_slot and anchor_slot if they are backfilled.