-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use oldest_block_slot to break off pruning payloads #6745
Conversation
Co-authored-by: Michael Sproul <micsproul@gmail.com>
@mergify queue |
🛑 The pull request has been removed from the queue
|
@mergify dequeue |
This pull request has been removed from the queue for the following reason: Pull request #6745 has been dequeued by a You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
✅ The pull request has been removed from the queue
|
@mergify requeue |
✅ This pull request will be re-embarked automaticallyThe followup |
🛑 The pull request has been removed from the queue
|
@mergify dequeue |
This pull request has been removed from the queue for the following reason: Pull request #6745 has been dequeued by a You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
✅ The pull request has been removed from the queue
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 722573f |
Issue Addressed
Lighthouse DB persists an "anchor" which has some useful data. One is the
anchor_slot
. Tree-states on the hot DB wants to use that value and change it's meaning slightly. The only blocker for that change istry_prune_execution_payloads
which uses the anchor_slot as optimization to break of early the pruning routine.BUT it's an easy fix. From @michaelsproul
ref dapplion#39 (comment)
Proposed Changes
This PR implements option 3 of the above citation, quite painless