Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ineffectual block RPC limits post merge #6798

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Remove ineffectual block RPC limits post merge #6798

merged 2 commits into from
Jan 15, 2025
+9 −326

Conversation

dapplion
Copy link
Collaborator

@dapplion dapplion commented Jan 13, 2025 •
edited
Loading

Issue Addressed

After the merge the max SSZ size of a block is absurdly big. The size is actually bound by other constants, so computing the fork's actual max size is pointless.

We can get rid of more fork boilerplate.

Close #6790

Proposed Changes

Use bellatrix's max value in block's rpc_block_limits_by_fork for post-merge forks

@dapplion dapplion requested a review from jxs as a code owner January 13, 2025 08:34
@dapplion dapplion added the ready-for-review The code is ready for review label Jan 13, 2025
@pawanjay176 pawanjay176 self-requested a review January 13, 2025 22:50
@realbigsean realbigsean self-requested a review January 14, 2025 00:03
jimmygchen
jimmygchen requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay to removing more code \o/
I think there are a few more things we can remove. Please see comments.

@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jan 15, 2025
@dapplion dapplion added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jan 15, 2025
@dapplion dapplion requested a review from jimmygchen January 15, 2025 06:10
jimmygchen
jimmygchen approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! -300 lines 🔪

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jan 15, 2025
@jimmygchen
Copy link
Member

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Jan 15, 2025 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at b1a19a8

mergify bot added a commit that referenced this pull request Jan 15, 2025
@mergify
Merge of #6798
aadcb1d
@mergify mergify bot mentioned this pull request Jan 15, 2025
Closed
5 tasks
@mergify mergify bot merged commit b1a19a8 into sigp:unstable Jan 15, 2025
30 checks passed
@jimmygchen jimmygchen mentioned this pull request Jan 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmygchen jimmygchen jimmygchen approved these changes

@jxs jxs Awaiting requested review from jxs jxs is a code owner

@pawanjay176 pawanjay176 Awaiting requested review from pawanjay176

@realbigsean realbigsean Awaiting requested review from realbigsean

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dapplion @jimmygchen