Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Current main branch has a foot gun for nested List/Vectors. The code below will panic on
tree_hash_root
becausel_sub
still has pending updates. Ethereum consensus does have many nested complex types that involve mutability, but it would be nice to remove the possibility of runtime errors if there's not much overhead.Impl
This PR introduces a new trait
PendingUpdates
that all values of List / Vector must implement. I'll take suggestions for a better name, since this will be very prevalent in the Lighthouse codebase.@michaelsproul comments that the compiler may optimize an
apply
implementation inside of thefor_each_mut
loop away. However I'm not sure if that's the case with a Result involved + the current impl. Open to feedback.Next
PendingUpdates
for structs