Abstract over U: UpdateMap more
#61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had only partly abstracted over the type
Uused for storing pending updates to lists/vectors. This PR updates several of the trait implementations so that they work with any choice ofU, not just the defaultVecMap.It may be advantageous to use a different map type now that the validator set has grown. The size of a
VecMapisO(largest index), so I suspect we are allocating a lot of very large vecs on networks with millions of validators (mainnet, Holesky). ABTreeMapmay be more efficient in terms of speed and memory usage at this point. I will do some benchmarks with Lighthouse against this branch before merging.