-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement TreeHash for bitfield #18
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
==========================================
+ Coverage 79.66% 79.67% +0.01%
==========================================
Files 6 6
Lines 295 310 +15
==========================================
+ Hits 235 247 +12
- Misses 60 63 +3 ☔ View full report in Codecov by Sentry. |
New release is out for |
9109272
to
51b88a8
Compare
I could use this one for sigp/lighthouse#6609, any chance we can get it merged? 🙏 My understanding is that @macladson needs to add a tree-hash test to satisfy teh bot. |
The bot isn't meant to block the merge due to this config:
We can just ignore it for now |
I'll add a test anyway, seeing as 0% coverage looks terrible. |
In preparation for EIP-7495, bitfield has been moved to https://github.com/sigp/ethereum_ssz.
This PR implements
TreeHash
for bothBitVector
andBitList
for those types.Requires sigp/ethereum_ssz#25