Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TreeHash for bitfield #18

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Conversation

macladson
Copy link
Member

In preparation for EIP-7495, bitfield has been moved to https://github.com/sigp/ethereum_ssz.

This PR implements TreeHash for both BitVector and BitList for those types.

Requires sigp/ethereum_ssz#25

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.67%. Comparing base (12d828c) to head (2536b81).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tree_hash/src/impls.rs 68.75% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   79.66%   79.67%   +0.01%     
==========================================
  Files           6        6              
  Lines         295      310      +15     
==========================================
+ Hits          235      247      +12     
- Misses         60       63       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tree_hash/Cargo.toml Outdated Show resolved Hide resolved
@michaelsproul
Copy link
Member

New release is out for ethereum_ssz:

https://github.com/sigp/ethereum_ssz/releases/tag/v0.8.0

@paulhauner
Copy link
Member

paulhauner commented Dec 19, 2024

I could use this one for sigp/lighthouse#6609, any chance we can get it merged? 🙏

My understanding is that @macladson needs to add a tree-hash test to satisfy teh bot.

@michaelsproul
Copy link
Member

The bot isn't meant to block the merge due to this config:

informational: true

We can just ignore it for now

@michaelsproul
Copy link
Member

I'll add a test anyway, seeing as 0% coverage looks terrible.

@michaelsproul michaelsproul merged commit 5f2102a into sigp:main Dec 20, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants