Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sigstore-review-bot #509

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

bobcallaway
Copy link
Member

Summary

Release Note

Documentation

Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested review from a team as code owners November 4, 2024 12:37
Copy link

github-actions bot commented Nov 4, 2024

🍹 preview on sigstore-github-sync/sigstore/github-prod

Pulumi report
  Previewing update (sigstore/github-prod)

View Live: https://app.pulumi.com/sigstore/sigstore-github-sync/github-prod/previews/16ffa2cf-2f97-4b8d-a788-0338371ae4f7

@ Previewing update.....
pulumi:pulumi:Stack: (same)
  [urn=urn:pulumi:github-prod::sigstore-github-sync::pulumi:pulumi:Stack::sigstore-github-sync-github-prod]
  ~ github:index/teamMembership:TeamMembership: (update)
      [id=6463637:cpanato]
      [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/teamMembership:TeamMembership::cpanato-gitsign-codeowners]
      [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_3_2::fc324c44-57b2-4a20-a304-fbcea50f90e7]
    ~ role: "maintainer" => "member"
  ~ github:index/branchProtection:BranchProtection: (update)
      [id=BPR_kwDOFotDCM4DA1RL]
      [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/branchProtection:BranchProtection::root-signing-main]
      [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_3_2::fc324c44-57b2-4a20-a304-fbcea50f90e7]
    ~ restrictPushes: [
        ~ [0]: {
                ~ pushAllowances: [
                    ~ [0]: "U_kgDOByoNQQ" => "T_kwDOBDzYIc4AYVWd"
                    ~ [1]: "T_kwDOBDzYIc4AYVWd" => "MDQ6VXNlcjg2ODM3MzY5"
                      [2]: "T_kwDOBDzYIc4AZiLE"
                    - [3]: "MDQ6VXNlcjg2ODM3MzY5"
                  ]
              }
      ]
  ~ github:index/branchProtection:BranchProtection: (update)
      [id=BPR_kwDOFotDCM4DEmYE]
      [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/branchProtection:BranchProtection::root-signing-publish]
      [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_3_2::fc324c44-57b2-4a20-a304-fbcea50f90e7]
    ~ restrictPushes: [
        ~ [0]: {
                ~ pushAllowances: [
                    ~ [0]: "U_kgDOByoNQQ" => "T_kwDOBDzYIc4AYVWd"
                    ~ [1]: "T_kwDOBDzYIc4AYVWd" => "MDQ6VXNlcjg2ODM3MzY5"
                    - [2]: "MDQ6VXNlcjg2ODM3MzY5"
                  ]
              }
      ]
@ Previewing update....
  - github:index/repositoryCollaborator:RepositoryCollaborator: (delete)
      [id=root-signing:sigstore-review-bot]
      [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/repositoryCollaborator:RepositoryCollaborator::root-signing-sigstore-review-bot]
      [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_3_2::fc324c44-57b2-4a20-a304-fbcea50f90e7]
      permission               : "push"
      permissionDiffSuppression: false
      repository               : "root-signing"
      username                 : "sigstore-review-bot"
  - github:index/membership:Membership: (delete)
      [id=sigstore:sigstore-review-bot]
      [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/membership:Membership::sigstore-review-bot]
      [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_3_2::fc324c44-57b2-4a20-a304-fbcea50f90e7]
      downgradeOnDestroy: false
      role              : "member"
      username          : "sigstore-review-bot"
Resources:
  ~ 3 to update
  - 2 to delete
  5 changes. 588 unchanged
  

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we terminate that bot as well? i mean delete the account

@bobcallaway
Copy link
Member Author

should we terminate that bot as well? i mean delete the account

yes, i can do that but the permissions need to be removed while the account still exists

@bobcallaway bobcallaway merged commit 93ad34b into sigstore:main Nov 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants