Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add (selftest) virtual environment management #187

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add (selftest) virtual environment management #187

wants to merge 2 commits into from

Conversation

jku
Copy link
Member

@jku jku commented Jan 14, 2025 •
edited
Loading

Two goals:

  • Make local testing easy when self test requirements (sigstore-python) and actual test suite requirements are different
  • Simplify self test setup in the self test workflow

Changes:

  • self test requirements are separated into selftest-requirements.txt (similar unused tools/requirements.txt was removed)
  • Makefile now creates a separate virtual environment selftest-env for selftest sigstore client
  • sigstore-python-conformance expects to find the sigstore binary in selftest-env
  • workflow is simplified similarly

The fact that sigstore-python-conformance now requires the venv to exist is a bit restricting: but it works and makes issues like #182 locally debuggable -- if other options are needed later on it will be easy to add a env variable or something to override the binary location

@jku jku changed the title Add virtual environment management Add (selftest) virtual environment management Jan 14, 2025
@jku jku requested a review from woodruffw January 14, 2025 10:21
@jku jku linked an issue Jan 14, 2025 that may be closed by this pull request
improve selftest invocation #185
Open
@jku jku mentioned this pull request Jan 14, 2025
Open
@jku
Copy link
Member Author

jku commented Jan 15, 2025

  • self test requirements are separated into sigstore-requirements.txt

selftest-requirements.txt (and selftest-env for the directory name) might be more descriptive.

jku added 2 commits January 25, 2025 12:31
@jku
Add virtual environment management
65b0895 
* self test requirements are separated into sigstore-requirements.txt
* Makefile now creates a separate venv for selftest sigstore client
* sigstore-python-conformance expects to find the sigstore binary in the
  venv
* workflow is simplified similarly

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
@jku
Naming: change sigstore-env to selftest-env
39440fd 
This hopefully makes it clearer what it is. same goes
for selftest-requirements.txt

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
@jku jku force-pushed the virtual-env-management branch from 3a6d53c to 39440fd Compare January 25, 2025 10:40
@jku
Copy link
Member Author

jku commented Jan 25, 2025 •
edited
Loading

  • Rebased on main
  • Did the rename I suggested myself in previous comment: "selftest" seems more useful as name than "sigstore"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodruffw woodruffw Awaiting requested review from woodruffw

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improve selftest invocation
1 participant
@jku