Move hosting to SSP #173
Move hosting to SSP #173
Conversation
This will necessitate either a server upgrade or a new server, but is done to allow us to add features to more recent versions of modules such as queuedjobs
These implement the cronjobs that addons uses. They’re built this way to ensure safe deployment to a multi-server environment. NOTE: The ElasticSearch cron isn’t included yet, until that feature is working on SSP.
Generally speaking, the addons that fail their download are legacy entries that exist on packages but not github. Deleting them is as such reasonable. If the issue is temporary, then these records will be recreated on the next execution. Note that if the issue is permanent, these entries will be continually deleted and recreated. It may be better to set a status flag instead, but that will need to be passed into elasticsearch and applied to our default view-list and search queries.
The jobs are taking more than an hour to run, so running them hourly isn’t practical.
Temp may is space-restricted on SSP and so a hidden folder in there runs out of disk. This sets up a new folder on the mounted EBS. Making it a hidden pathname prevents web access.
composer.json
Outdated
| }, | ||
| { | ||
| "type": "vcs", | ||
| "url": "https://github.com/sminnee/silverstripe-queuedjobs.git" |
There was a problem hiding this comment.
Is there a blocker we need to get merged into queuedjobs first?
There was a problem hiding this comment.
Good point I'll have a look on hackday. This stuff may have already made its ways in.
| @@ -227,6 +238,8 @@ private function updateVersion(Addon $addon, Version $package) | |||
| $version->License = $package->getLicense(); | |||
| // $version->Support = $package->getSupport(); | |||
|
|
|||
| echo " - Processed version {$version->Version}\n"; | |||
There was a problem hiding this comment.
This is a side note: I'd really love to see an output interface used instead of direct echos. Related silverstripe/silverstripe-framework#7509 and silverstripe/silverstripe-framework#6524
There was a problem hiding this comment.
I agree but I think that would be an API breakage, so I don't think it's part of this PR?
|
Changes look good overall - we need to ensure any queuedjobs requirements are merged in (in a perfect world) before merging. Here are my concerns with the approach:
|
composer.json
Outdated
| @@ -28,7 +24,7 @@ | |||
| "symfony/finder": "^2.8", | |||
| "symfony/yaml": "^2.8", | |||
| "guzzlehttp/guzzle": "^6", | |||
| "symbiote/silverstripe-queuedjobs": "dev-queue-buildtask as 3.x-dev", | |||
| "symbiote/silverstripe-queuedjobs": "3.x-dev as 3.1.0", | |||
There was a problem hiding this comment.
I've updated the branch alias on queuejobs so you can use 3.1.x-dev now without aliasing it
composer.json
Outdated
| @@ -28,7 +24,7 @@ | |||
| "symfony/finder": "^2.8", | |||
| "symfony/yaml": "^2.8", | |||
| "guzzlehttp/guzzle": "^6", | |||
| "symbiote/silverstripe-queuedjobs": "dev-queue-buildtask as 3.x-dev", | |||
| "symbiote/silverstripe-queuedjobs": ">=3.1.0@dev", | |||
There was a problem hiding this comment.
How's this @robbieaverill ?
Completed jobs should be garbage-collected, right? If not, we should fix that... |
|
Merge on green |
This PR has the code changes needed to move addons.silverstripe.org to SSP. You can see it on our company network here: https://ssaddons-uat.sites.silverstripe.com
The most notable feature not working are the helpful robot score, due to #172.