CMS 5: Still using various deprecated lifecycle events which should be avoided

[GuySartorelli]

#1312 results in some regressions which we've decided to handle as separate issues. This is one of those.

Many of our react components implement a componentWillReceiveProps method. This results in a console warning that this method is deprecated. We should refactor our components to not use this method to avoid upgrade pains in the future.
There may be other deprecated lifecycle events in use as well.

Acceptance Criteria

• None of the react components in supported modules use componentWillReceiveProps
• No other deprecated lifecycle events are used in supported modules

Notes

• see this blog post which includes more information and suggestions for alternative solutions for the problems this method typically solves.
• If it comes to a point where it's just too hard to refactor, we can use npx react-codemod rename-unsafe-lifecycles to suppress console warnings - but that should be a last resort (we'll have to remove them eventually)

PRs

• ENH Do not use deprecated lifecycle methods silverstripe-versioned-admin#280
• MNT Update test label silverstripe-asset-admin#1343
• MNT Update comment #1490

[maxime-rainville]

Sadly we will not get to this in CMS5.

[GuySartorelli]

Reopening - we could happily do this in a minor and it does need to be done eventually.

[emteknetnz]

As far as I can tell we've overestimated the amount of work required in this issue, I could only find a single relevant component that needed updating.

All the other components were updated as part of #1312

I search searched sink 5.0 for the following strings that would mean the deprecated lifecycle methods are actually being called:

• "componentWillMount("
• "componentWillReceiveProps("
• "componentWillUpdate("

It only matched bundle.js style files + the 2x files included in the PRs above

[GuySartorelli]

PRs merged