FIX Get JS tests passing again #1330
Conversation
GuySartorelli
force-pushed
the
pulls/2/js-tests
branch
from
e3cec27 to
964444b
Compare
GuySartorelli
force-pushed
the
pulls/2/js-tests
branch
from
964444b to
a1b1cfe
Compare
| @@ -0,0 +1,6 @@ | |||
| { | |||
There was a problem hiding this comment.
For non-admin modeles it seems that this config needs to be in babel.config.json rather than in package.json/.babelrc - https://babeljs.io/docs/en/configuration#whats-your-use-case
| item = ReactTestUtils.renderIntoDocument( | ||
| <AssetDropzone {...props} /> | ||
| ); | ||
| item = new AssetDropzone(); | ||
| }); | ||
|
|
||
| it('should set this.dropzone to null', () => { | ||
| item.dropzone = 1; | ||
| item.constructor(props); | ||
|
|
There was a problem hiding this comment.
Can no longer call constructor() directly on react components, need to use the new keyword
| /* global jest, jasmine, describe, it, expect, beforeEach */ | ||
| /* global jest, describe, it, expect, beforeEach */ |
There was a problem hiding this comment.
jasmine isn't used or installed
| .mockReturnValueOnce({ confirm: Promise.resolve(), callback: callbackMockFn }); | ||
| .mockReturnValueOnce({ confirm: () => Promise.resolve(), callback: callbackMockFn }); |
There was a problem hiding this comment.
This wasn't actually hitting the bit of code it's meant to be testing, because Promise.resolve() returns an object, and the handleChangeValue() method in the BulkActions component has a typeof option.confirm === 'function' condition.
| return bulkActions.handleChangeValue(event).then(() => { | ||
| expect(callbackMockFn).toBeCalled(); | ||
| expect(callbackMockFn).not.toBeCalled(); |
There was a problem hiding this comment.
This test was literally not testing the right thing before. I only caught this because the test started failing with a UnhandledPromiseRejection because the rejected promise wasn't being caught.
| (url, resolve, reject) => { reject(); } | ||
| (url, resolve, reject) => { reject(4); } |
There was a problem hiding this comment.
Added to help debug an issue where one of the promise rejections wasn't being caught. Left in so it's easier to find in the future.
The output of the error includes whatever is passed in here, so if it said the issue was with a reject that had 4 passed in we can just search for reject(4) and there it is.
| jasmine.objectContaining({ | ||
| expect.objectContaining({ |
There was a problem hiding this comment.
Jasmine isn't installed - expect.objectContaining() does the same thing that used to.
| "testEnvironment": "jsdom", | ||
| "roots": [ | ||
| "client/src" | ||
| ], | ||
| "moduleNameMapper": { | ||
| "^react-dom/client$": "react-dom-16", | ||
| "^react-dom((/.*)?)$": "react-dom-16$1", | ||
| "^react((/.*)?)$": "react-16$1" | ||
| }, |
There was a problem hiding this comment.
This and the inclusion of react16 in dev deps reflects how I got tests working in admin in silverstripe/silverstripe-admin#1389
see silverstripe/silverstripe-admin#1419
| "enzyme": "^3.11.0", | ||
| "enzyme-adapter-react-16": "^1.15.6", |
There was a problem hiding this comment.
The tests use enzyme. This should have already been here.
| "babel": { | ||
| "presets": [ | ||
| "@babel/preset-env", | ||
| "@babel/preset-react" | ||
| ] | ||
| } |
There was a problem hiding this comment.
We're using the babel.config.json file instead.
Using
FIXprefix because it affects src files and therefore dist files.Parent issue