MNT Fix js tests #1320
Closed
MNT Fix js tests #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
commented
Jan 12, 2023
| @@ -0,0 +1,6 @@ | |||
| { | |||
There was a problem hiding this comment.
For non-admin modeles it seems that this config needs to be in babel.config.json rather than in package.json/.babelrc - https://babeljs.io/docs/en/configuration#whats-your-use-case
emteknetnz
commented
Jan 12, 2023
| item = ReactTestUtils.renderIntoDocument( | ||
| <AssetDropzone {...props} /> | ||
| ); | ||
| item = new AssetDropzone(); |
There was a problem hiding this comment.
Cannot no longer call constructor() directly on react components, need to use the new keyword
emteknetnz
commented
Jan 12, 2023
| @@ -44,7 +44,8 @@ | |||
| ], | |||
| "transform": { | |||
| ".*": "babel-jest" | |||
| } | |||
| }, | |||
| "testEnvironment": "jsdom" | |||
There was a problem hiding this comment.
This is required for things like 'document' to be globally available
emteknetnz
force-pushed
the
pulls/2/jstests
branch
2 times, most recently
from
43156b5 to
9d52f82
Compare
2 tasks
emteknetnz
force-pushed
the
pulls/2/jstests
branch
from
9d52f82 to
d832bac
Compare
|
Closed in favor of #1330 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-admin#1421
This is far from complete, I got as far as getting the admin js to be transformed for jest. There's still a bunch of broken jest tests, most notably AssetAdmin-test.js and AssetAdminRouter-test.js