Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Fix js tests #1320

Closed
wants to merge 1 commit into from
Closed

MNT Fix js tests #1320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions babel.config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For non-admin modeles it seems that this config needs to be in babel.config.json rather than in package.json/.babelrc - https://babeljs.io/docs/en/configuration#whats-your-use-case

"presets": [
"@babel/preset-env",
"@babel/preset-react"
]
}
7 changes: 1 addition & 6 deletions client/src/components/AssetDropzone/tests/AssetDropzone-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,10 @@ describe('AssetDropzone', () => {
let item = null;

beforeEach(() => {
item = ReactTestUtils.renderIntoDocument(
<AssetDropzone {...props} />
);
item = new AssetDropzone();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot no longer call constructor() directly on react components, need to use the new keyword

});

it('should set this.dropzone to null', () => {
item.dropzone = 1;
item.constructor(props);

expect(item.dropzone).toBe(null);
});
});
Expand Down
12 changes: 4 additions & 8 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@
],
"transform": {
".*": "babel-jest"
}
},
"testEnvironment": "jsdom"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required for things like 'document' to be globally available

},
"devDependencies": {
"@silverstripe/eslint-config": "^1.0.0-alpha6",
Expand Down Expand Up @@ -75,6 +76,7 @@
"graphql-fragments": "^0.1.0",
"graphql-tag": "^2.12.6",
"griddle-react": "^0.8.2",
"jest-environment-jsdom": "^29.3.1",
"merge": "^2.1.1",
"modernizr": "^3.12.0",
"prop-types": "^15.8.1",
Expand All @@ -99,11 +101,5 @@
},
"browserslist": [
"defaults"
],
"babel": {
"presets": [
"@babel/preset-env",
"@babel/preset-react"
]
}
]
}
Loading