Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Remove redundant memoisation #1456

Merged

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Feb 9, 2023

Don't squash

There are two commits here.

Commit one

Required to resolve a false-negative result in cms jest test:

Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:
1. You might have mismatching versions of React and the renderer (such as React DOM)
2. You might be breaking the Rules of Hooks
3. You might have more than one copy of React in the same app
See https://fb.me/react-invalid-hook-call for tips about how to debug and fix this problem.

Obviously that is nonsense - but this memoisation is redundant anyway, since we're storing the result as a global variable.

Commit two

Removes redundant reference to "jasmine" which isn't used anymore and isn't available.

Parent issue

@emteknetnz emteknetnz merged commit 94e64c5 into silverstripe:2.0 Feb 13, 2023
@emteknetnz emteknetnz deleted the pulls/2/no-memo-for-emotioncss branch February 13, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants