Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Handle moving files to root folder #1534

Merged
merged 1 commit into from
Jan 6, 2025
Merged

FIX Handle moving files to root folder #1534

merged 1 commit into from
Jan 6, 2025

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jan 6, 2025 •
edited
Loading

Issue #1529

Note that while the parent issue says "Make sure to add a behat test for this when fixing it." since this is a PHP issue rather than a JS issue, a regular unit test is more appropriate

@emteknetnz emteknetnz mentioned this pull request Jan 6, 2025
Closed
@emteknetnz emteknetnz marked this pull request as ready for review January 6, 2025 04:31
GuySartorelli
GuySartorelli approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would have been good to also add a behat test as there are other things that could go wrong that would only be caught in an end-to-end test, but I suppose it's not strictly necessary.

Works well locally.

@GuySartorelli GuySartorelli merged commit 5af6c1e into silverstripe:3.0 Jan 6, 2025
17 checks passed
@GuySartorelli GuySartorelli deleted the pulls/3.0/dnd-root branch January 6, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli