Correct URL for categories if Blog is on /home #804
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
true
in BlogObject->getLink() to get correct URL for categories also if Blog is on /homeIf Blog is on
/home
,$this->Blog()->Link()
returns just/
but should return/home
for categories. Addingtrue
as parameter in https://github.com/silverstripe/silverstripe-blog/blob/4/src/Model/BlogObject.php#L86 to->Link()
fixes this. See also:https://github.com/silverstripe/silverstripe-cms/blob/5/code/Model/SiteTree.php#L715
Manual testing steps
Install Blog on
/home
and see categories failIssues
Pull request checklist