FIX re-label forgot password for uniq id #11568
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewandante
force-pushed
the
FIX_lost_password_for_non_email
branch
2 times, most recently
from
e2853d9 to
c5843c9
Compare
2 tasks
GuySartorelli
requested changes
Jan 21, 2025
Comment on lines
28
to
35
| $uniqueIdentifier = Member::config()->get('unique_identifier_field'); | ||
| if ($uniqueIdentifier === 'Email') { | ||
| $emailField = EmailField::create('Email', _t('SilverStripe\\Security\\Member.EMAIL', 'Email')); | ||
| } else { | ||
| // This field needs to still be called Email, but we can re-label it | ||
| $emailField = TextField::create('Email', _t('SilverStripe\\Security\\Member.LOSTPASSWORDLABEL', $uniqueIdentifier)); | ||
| } |
There was a problem hiding this comment.
Might be worth getting a member singleton and calling $singleton->fieldLabel($uniqueIdentifier) to get the field label. Then we don't need any branching logic at all.
There was a problem hiding this comment.
That's a good trick! Still need to split on fieldtype though I think, the email validation on the email field still seems valuable.
andrewandante
force-pushed
the
FIX_lost_password_for_non_email
branch
from
c5843c9 to
7e5eeb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new lang option and a decent default for non-Email unique identifier fields.
Manual testing steps
Set
unique_identifier_fieldto something non-email.See that it changes the field label.
See that you can change the field label via an app
en.ymlIssues
Fixes #11567
Pull request checklist