Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General usability Improvements to All Reports View #196

Closed
4 tasks done
n8-dev opened this issue Oct 3, 2024 · 8 comments
Closed
4 tasks done

General usability Improvements to All Reports View #196

n8-dev opened this issue Oct 3, 2024 · 8 comments

Comments

@n8-dev
Copy link

n8-dev commented Oct 3, 2024

Description

There are 2 main improvements that are desireable.

1 Allow searching via either Title or Description with partialText matching.

Reason, its difficult to find your report when you have more than 1 pages worth (iirc 25+)

2 Set default_sort to be via title.

It currently is something else... Maybe via filepath or namespace.

To find a report that you want on load you have to click the title sort twice to have anything logical.

Additional context or points of discussion

Appears that the base Gridfield here isn't using a default gridField scaffold class which makes custom override somewhat challenging.

Also we really should allow some of this details to be changed via config mechanics, and a couple extension hooks 🙏

I may be able to get this PR under way; and therefore have checked the intend to implement for now

Validations

  • You intend to implement the feature yourself
  • You have read the contributing guide
  • You strongly believe this feature should be in core, rather than being its own community module
  • You have checked for existing issues or pull requests related to this feature (and didn't find any)

PRs

@GuySartorelli
Copy link
Member

Sounds good to me.

@GuySartorelli
Copy link
Member

Maybe split the PRs when you do it - have one for the filter functionality and a separate one for sorting. That way if there's any controversy with either piece of functionality, the other can still get merged in without waffling about.

@mfendeksilverstripe
Copy link
Contributor

Fixed in #197

@GuySartorelli GuySartorelli self-assigned this Oct 11, 2024
@GuySartorelli
Copy link
Member

PR merged.

@mfendeksilverstripe or @n8-dev can one of you please raise a PR for the 5 branch of https://github.com/silverstripe/developer-docs/ to add a note about this to the CMS 5.4 changelog?

Can be a full section if you think it warrants it, or just add a bullet point to the "other new features" section.

@mfendeksilverstripe
Copy link
Contributor

Leaving this one with you @n8-dev

@n8-dev
Copy link
Author

n8-dev commented Oct 17, 2024

I'll try and do this next week!

Clean up the issue content too if needed etc

@n8-dev
Copy link
Author

n8-dev commented Oct 30, 2024

@GuySartorelli
Copy link
Member

PRs merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants