-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH Reports list filtering and pagination. #197
ENH Reports list filtering and pagination. #197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, thanks! A few changes requested below.
Please also bump the framework dependency to |
Have pushed up the requested changes @GuySartorelli , please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, works well locally.
Given there's no behat testing for this module, I won't ask for tests to be added for this change.
Thanks for adding this! It's a nice quality of life feature.
All the built-in reports look silly for not having descriptions now lol but we can deal with that separately if we ever get around to it.
ENH Reports list filtering and pagination.
Description
Minor quality of life improvements to the reports list in the Reports admin.
Manual testing steps
Issues
Pull request checklist