Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Don't keep empty files #28

Merged
merged 2 commits into from
May 7, 2024
Merged

FIX Don't keep empty files #28

merged 2 commits into from
May 7, 2024

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented May 7, 2024 •
edited
Loading

  • Deletes yaml files if there's nothing under the lang key (e.g. has en: but nothing inside that)
  • Deletes js source files if there's nothing in it (empty array)
  • Deletes js dist files if there's no corresponding js source file

Needs to be manually tagged after merging

Issue

@GuySartorelli
FIX Don't keep empty files
60a0ec2 
Files can be empty if previous runs provided incorrect values (e.g.
english strings inside non-english files), and subsequent runs remove
the errant values.
@GuySartorelli
FIX Allow committing deletion of files
379962c
@GuySartorelli GuySartorelli mentioned this pull request May 7, 2024
Closed
@emteknetnz emteknetnz merged commit 72ae09b into silverstripe:1.1 May 7, 2024
1 check passed
@emteknetnz emteknetnz deleted the pulls/1.1/remove-empty-files branch May 7, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz