SSINTER-253: Versioned snapshots > CMS 5 upgrade > Pagination

[poyjavier]

SSINTER-253: Versioned snapshots > CMS 5 upgrade > Pagination

Bug fixes:

• Fixed version list not displayed when it is more than 30 items
• Fixed pagination not working
• Removed Griddle. Only used before to match styling of ThumbnailView.js (Assuming this component's pagination not working too due to griddle-react@1.13.1 new architecture.)
• Added custom pagination with styling that matches the old one.
• Confirmed SS CMS 5 compatibility.

Issues

• https://silverstripe.atlassian.net/browse/SSINTER-253
• Pagination breaks history viewer #104

Checklist:

• The commit messages follow our commit message guidelines
• The PR follows our contribution guidelines
• Code changes follow our coding conventions
• This change is covered with tests (or tests aren't necessary for this change)
• Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
• CI is green

[mfendeksilverstripe]

Looks like you're missing the dist files. Please make sure to build the dist files and commit the changes.

[mfendeksilverstripe]

Overall it's looking good 👍 Left some comments to follow up on though.

[mfendeksilverstripe]

I'm a bit concerned about the scope of these styles. Maybe we can limit this by wrapping all of the new styles within .history-viewer?

[mfendeksilverstripe]

I noticed that clicking pagination button within the inline editor causes to trigger block save action. This is not the case for previous and next button for some reason. The pagination should not be triggering any other actions. Can you please check what's causing this?

[poyjavier]

@mfendeksilverstripe Can you please provide the steps to replicate this? Not able to replicate this behaviour. Cheers

[mfendeksilverstripe]

As per our conversation, we will separate this issue out.

[poyjavier]

Better approach fix which aligns styling of other griddle tables.