FIX Remove implicitly added item #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabina-talipova
force-pushed
the
pulls/1.13/remove-implicitly-added-item
branch
from
d0c0890 to
528ebe5
Compare
maxime-rainville
requested changes
Oct 26, 2023
sabina-talipova
force-pushed
the
pulls/1.13/remove-implicitly-added-item
branch
4 times, most recently
from
2ae54c9 to
c2a4961
Compare
sabina-talipova
force-pushed
the
pulls/1.13/remove-implicitly-added-item
branch
from
c2a4961 to
fa265ef
Compare
maxime-rainville
requested changes
Oct 30, 2023
There was a problem hiding this comment.
Consider adding an optional $message parameter to the assertChangeSetLooksLike helper method. That could help make the test more readable.
You could provide assumption like:
- Removing an explicitly defined ChangeSetItem removes all its implicit ChangeSetItems.
- Removing an explicitly defined ChangeSetItem does not remove its implicit ChangeSetItem if that item is also referenced by another a third one.
- Removing an explicitly defined ChangeSetItem does not remove its implicit ChangeSetItem if that item is also explicitly added to the changeset
This is more in the nice to have category.
tests/php/ChangeSetTest.php
Outdated
| $changeset->addObject($mid1); | ||
| $changeset->addObject($mid2); | ||
| $changeset->addObject($mid3); | ||
| $changeset->addObject($end1); // Item end1 explisitly added to ChangeSet |
There was a problem hiding this comment.
Suggested change
| $changeset->addObject($end1); // Item end1 explisitly added to ChangeSet | |
| $changeset->addObject($end1); // Item end1 explicitly added to ChangeSet |
sabina-talipova
force-pushed
the
pulls/1.13/remove-implicitly-added-item
branch
from
fa265ef to
53c86be
Compare
sabina-talipova
force-pushed
the
pulls/1.13/remove-implicitly-added-item
branch
from
53c86be to
d614204
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We should remove implicitly added item together with parent item even if ChangeSet was already published.
Parent issue