Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for better parametrisation of GA_Detect.py command-line script #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dnouri
Copy link
Contributor

@dnouri dnouri commented Jun 20, 2020

This includes the ability to configure the metars file via the
command-line. The loading of the metars file has been moved to the
main process to enable this.

@dnouri dnouri force-pushed the feature/ga-detect-cli branch 3 times, most recently from 056309f to da748ce Compare June 21, 2020 21:09
dnouri added 2 commits June 22, 2020 23:39
This includes the ability to configure the metars file via the
command-line.  The loading of the metars file has been moved to the
main process to enable this.
@dnouri dnouri force-pushed the feature/ga-detect-cli branch from da748ce to 1af0bae Compare June 22, 2020 21:47
@dnouri
Copy link
Contributor Author

dnouri commented Jun 22, 2020

Added a little test suite that checks the output of CSV files when processing flights in OS_201908100000_VABB.pkl.

@dnouri
Copy link
Contributor Author

dnouri commented Jun 22, 2020

By the way, @simonrp84, I tried to split up my recent work into multiple pull requests so that they're easier for you to review. You may want to look at this PR and #3 together. #4 will produce a small merge conflict, and I'm happy to rebase #4 once this one has been merged. Thanks.

@simonrp84
Copy link
Owner

Thanks for the PRs, I'll take a look at these as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants