Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added unit tests for shipping free module - FreeShippingServiceProvider #1080

Merged

Conversation

Arunkumar0610
Copy link
Contributor

@Arunkumar0610 Arunkumar0610 commented Jan 10, 2024

added tests for #1037 #1069 #1076
SimplCommerce.Module.ShippingFree -> Services- FreeShippingServiceProvider

Copy link
Member

@hishamco hishamco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please few suggestions, then I will merge

@hishamco hishamco merged commit 1cc3cfe into simplcommerce:master Jan 11, 2024
8 checks passed
@hishamco
Copy link
Member

Thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants