Fix codesniffer issues #420
php.yml
on: push
Annotations
10 errors and 24 warnings
ArgumentTypeCoercion:
src/Controller/AuthProcess.php#L106
src/Controller/AuthProcess.php:106:46: ArgumentTypeCoercion: Argument 1 of SimpleSAML\Auth\State::loadState expects string, but parent type scalar provided (see https://psalm.dev/193)
|
ArgumentTypeCoercion:
src/Controller/AuthProcess.php#L108
src/Controller/AuthProcess.php:108:70: ArgumentTypeCoercion: Argument 1 of SimpleSAML\Module\webauthn\WebAuthn\WebAuthnAbstractEvent::base64urlDecode expects string, but parent type null|scalar provided (see https://psalm.dev/193)
|
PossiblyNullArgument:
src/Controller/AuthProcess.php#L108
src/Controller/AuthProcess.php:108:70: PossiblyNullArgument: Argument 1 of SimpleSAML\Module\webauthn\WebAuthn\WebAuthnAbstractEvent::base64urlDecode cannot be null, possibly null value provided (see https://psalm.dev/078)
|
ArgumentTypeCoercion:
src/Controller/AuthProcess.php#L120
src/Controller/AuthProcess.php:120:46: ArgumentTypeCoercion: Argument 1 of base64_decode expects string, but parent type null|scalar provided (see https://psalm.dev/193)
|
PossiblyNullArgument:
src/Controller/AuthProcess.php#L120
src/Controller/AuthProcess.php:120:46: PossiblyNullArgument: Argument 1 of base64_decode cannot be null, possibly null value provided (see https://psalm.dev/078)
|
ArgumentTypeCoercion:
src/Controller/AuthProcess.php#L163
src/Controller/AuthProcess.php:163:13: ArgumentTypeCoercion: Argument 1 of SimpleSAML\Module\webauthn\WebAuthn\WebAuthnAuthenticationEvent::__construct expects string, but parent type null|scalar provided (see https://psalm.dev/193)
|
PossiblyNullArgument:
src/Controller/AuthProcess.php#L163
src/Controller/AuthProcess.php:163:13: PossiblyNullArgument: Argument 1 of SimpleSAML\Module\webauthn\WebAuthn\WebAuthnAuthenticationEvent::__construct cannot be null, possibly null value provided (see https://psalm.dev/078)
|
ArgumentTypeCoercion:
src/Controller/AuthProcess.php#L166
src/Controller/AuthProcess.php:166:27: ArgumentTypeCoercion: Argument 1 of base64_decode expects string, but parent type null|scalar provided (see https://psalm.dev/193)
|
PossiblyNullArgument:
src/Controller/AuthProcess.php#L166
src/Controller/AuthProcess.php:166:27: PossiblyNullArgument: Argument 1 of base64_decode cannot be null, possibly null value provided (see https://psalm.dev/078)
|
ArgumentTypeCoercion:
src/Controller/AuthProcess.php#L167
src/Controller/AuthProcess.php:167:27: ArgumentTypeCoercion: Argument 1 of base64_decode expects string, but parent type null|scalar provided (see https://psalm.dev/193)
|
PossiblyNullOperand:
src/Controller/RegProcess.php#L153
src/Controller/RegProcess.php:153:9: PossiblyNullOperand: Cannot concatenate with a possibly null null|scalar (see https://psalm.dev/080)
|
MissingReturnType:
src/Controller/WebAuthn.php#L90
src/Controller/WebAuthn.php:90:28: MissingReturnType: Method SimpleSAML\Module\webauthn\Controller\WebAuthn::workflowStateMachine does not have a return type, expecting 1|2|4 (see https://psalm.dev/050)
|
MissingParamType:
src/Controller/WebAuthn.php#L90
src/Controller/WebAuthn.php:90:49: MissingParamType: Parameter $state has no provided type (see https://psalm.dev/154)
|
MissingParamType:
src/Controller/WebAuthn.php#L120
src/Controller/WebAuthn.php:120:45: MissingParamType: Parameter $moduleConfig has no provided type (see https://psalm.dev/154)
|
MissingParamType:
src/Controller/WebAuthn.php#L120
src/Controller/WebAuthn.php:120:61: MissingParamType: Parameter $stateData has no provided type (see https://psalm.dev/154)
|
MissingConstructor:
src/WebAuthn/StateData.php#L16
src/WebAuthn/StateData.php:16:18: MissingConstructor: SimpleSAML\Module\webauthn\WebAuthn\StateData has an uninitialized property SimpleSAML\Module\webauthn\WebAuthn\StateData::$store, but no constructor (see https://psalm.dev/073)
|
MissingConstructor:
src/WebAuthn/StateData.php#L38
src/WebAuthn/StateData.php:38:19: MissingConstructor: SimpleSAML\Module\webauthn\WebAuthn\StateData has an uninitialized property SimpleSAML\Module\webauthn\WebAuthn\StateData::$usernameAttrib, but no constructor (see https://psalm.dev/073)
|
MissingConstructor:
src/WebAuthn/StateData.php#L45
src/WebAuthn/StateData.php:45:19: MissingConstructor: SimpleSAML\Module\webauthn\WebAuthn\StateData has an uninitialized property SimpleSAML\Module\webauthn\WebAuthn\StateData::$displaynameAttrib, but no constructor (see https://psalm.dev/073)
|
MissingConstructor:
src/WebAuthn/StateData.php#L50
src/WebAuthn/StateData.php:50:17: MissingConstructor: SimpleSAML\Module\webauthn\WebAuthn\StateData has an uninitialized property SimpleSAML\Module\webauthn\WebAuthn\StateData::$requestTokenModel, but no constructor (see https://psalm.dev/073)
|
MissingConstructor:
src/WebAuthn/StateData.php#L52
src/WebAuthn/StateData.php:52:19: MissingConstructor: SimpleSAML\Module\webauthn\WebAuthn\StateData has an uninitialized property SimpleSAML\Module\webauthn\WebAuthn\StateData::$minCertLevel2FA, but no constructor (see https://psalm.dev/073)
|
PropertyNotSetInConstructor:
tests/src/Controller/AuthProcessTest.php#L24
tests/src/Controller/AuthProcessTest.php:24:29: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\webauthn\Controller\AuthProcessTest::$config is not defined in constructor of SimpleSAML\Test\Module\webauthn\Controller\AuthProcessTest or in any methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
tests/src/Controller/AuthProcessTest.php#L27
tests/src/Controller/AuthProcessTest.php:27:22: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\webauthn\Controller\AuthProcessTest::$logger is not defined in constructor of SimpleSAML\Test\Module\webauthn\Controller\AuthProcessTest or in any methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
tests/src/Controller/AuthProcessTest.php#L30
tests/src/Controller/AuthProcessTest.php:30:23: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\webauthn\Controller\AuthProcessTest::$session is not defined in constructor of SimpleSAML\Test\Module\webauthn\Controller\AuthProcessTest or in any methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
tests/src/Controller/ManageTokenTest.php#L24
tests/src/Controller/ManageTokenTest.php:24:29: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\webauthn\Controller\ManageTokenTest::$config is not defined in constructor of SimpleSAML\Test\Module\webauthn\Controller\ManageTokenTest or in any methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
tests/src/Controller/ManageTokenTest.php#L27
tests/src/Controller/ManageTokenTest.php:27:15: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\webauthn\Controller\ManageTokenTest::$module_config is not defined in constructor of SimpleSAML\Test\Module\webauthn\Controller\ManageTokenTest or in any methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
tests/src/Controller/ManageTokenTest.php#L30
tests/src/Controller/ManageTokenTest.php:30:22: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\webauthn\Controller\ManageTokenTest::$logger is not defined in constructor of SimpleSAML\Test\Module\webauthn\Controller\ManageTokenTest or in any methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
tests/src/Controller/ManageTokenTest.php#L33
tests/src/Controller/ManageTokenTest.php:33:23: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\webauthn\Controller\ManageTokenTest::$session is not defined in constructor of SimpleSAML\Test\Module\webauthn\Controller\ManageTokenTest or in any methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
tests/src/Controller/RegProcessTest.php#L23
tests/src/Controller/RegProcessTest.php:23:29: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\webauthn\Controller\RegProcessTest::$config is not defined in constructor of SimpleSAML\Test\Module\webauthn\Controller\RegProcessTest or in any methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
tests/src/Controller/RegProcessTest.php#L26
tests/src/Controller/RegProcessTest.php:26:22: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\webauthn\Controller\RegProcessTest::$logger is not defined in constructor of SimpleSAML\Test\Module\webauthn\Controller\RegProcessTest or in any methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
tests/src/Controller/RegProcessTest.php#L29
tests/src/Controller/RegProcessTest.php:29:23: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\webauthn\Controller\RegProcessTest::$session is not defined in constructor of SimpleSAML\Test\Module\webauthn\Controller\RegProcessTest or in any methods called in the constructor (see https://psalm.dev/074)
|
Unit tests, PHP 8.2, ubuntu-latest:
vendor/simplesamlphp/simplesamlphp/src/SimpleSAML/Utils/HTTP.php#L819
Undefined array key "REQUEST_URI"
|
Unit tests, PHP 8.1, ubuntu-latest:
vendor/simplesamlphp/simplesamlphp/src/SimpleSAML/Utils/HTTP.php#L819
Undefined array key "REQUEST_URI"
|
Unit tests, PHP 8.1, windows-latest:
vendor/simplesamlphp/simplesamlphp/src/SimpleSAML/Utils/HTTP.php#L819
Undefined array key "REQUEST_URI"
|
Unit tests, PHP 8.2, windows-latest:
vendor/simplesamlphp/simplesamlphp/src/SimpleSAML/Utils/HTTP.php#L819
Undefined array key "REQUEST_URI"
|