Avoid broken XML-output when no prefix is set

simplesamlphp · Sep 6, 2024 · 900bfed · 900bfed
1 parent c76769a
commit 900bfed
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/Attribute.php b/src/Attribute.php
@@ -55,9 +55,9 @@ public function getNamespaceURI(): ?string
     /**
      * Collect the value of the namespacePrefix-property
      *
-     * @return string
+     * @return string|null
      */
-    public function getNamespacePrefix(): string
+    public function getNamespacePrefix(): ?string
     {
         return $this->namespacePrefix;
     }
@@ -108,7 +108,9 @@ public function toXML(DOMElement $parent): DOMElement
     {
         $parent->setAttributeNS(
             $this->getNamespaceURI(),
-            $this->getNamespacePrefix() . ':' . $this->getAttrName(),
+            ($this->getNamespacePrefix() !== null)
+                ? ($this->getNamespacePrefix() . ':' . $this->getAttrName())
+                : $this->getAttrName(),
             $this->getAttrValue(),
         );