Re-add element traits

simplesamlphp · Jan 16, 2025 · caf6942 · caf6942
1 parent d2b0100
commit caf6942
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/tests/Utils/Base64BinaryElement.php b/tests/Utils/Base64BinaryElement.php
@@ -29,5 +29,10 @@ final class Base64BinaryElement extends AbstractElement implements SchemaValidat
     public const SCHEMA = 'tests/resources/schemas/deliberately-wrong-file.xsd';
 
     /** @var string */
-    public const TEXTCONTENT_TYPE = Base64BinaryValue::class;
+    public const TEXTCONTENT_TYPE = AbstractElement::class; // Deliberately wrong class
+
+
+    /**
+     * NOTE: This class has some deliberately wrong values for testing purposes!!
+     */
 }
diff --git a/tests/XML/TypedTextContentTraitTest.php b/tests/XML/TypedTextContentTraitTest.php
@@ -40,17 +40,18 @@ public function testTypedContentPassesForBoolean(): void
     }
 
 
-    public function testTypedContentForBase64Binary(): void
+    public function testTypedContentFailsForWrongType(): void
     {
-        $file = 'tests/resources/xml/ssp_Base64BinaryElement.xml';
+        $file = 'tests/resources/xml/ssp_BooleanElement.xml';
         $chunk = DOMDocumentFactory::fromFile($file);
+        $chunk->documentElement->textContent = 'not-a-boolean';
 
-        $stringElt = Base64BinaryElement::fromXML($chunk->documentElement);
-        $this->assertInstanceOf(Base64BinaryElement::class, $stringElt);
+        $this->expectException(SchemaViolationException::class);
+        BooleanElement::fromXML($chunk->documentElement);
     }
 
 
-    public function testTypedContentFailsForWrongType(): void
+    public function testTypedContentFailsForWrongClass(): void
     {
         $file = 'tests/resources/xml/ssp_BooleanElement.xml';
         $chunk = DOMDocumentFactory::fromFile($file);