-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger platform-pipeline build after successful execution #38
Trigger platform-pipeline build after successful execution #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why would one need to trigger a build on master in another repo for pull-requests?
singnet/platform-pipeline projet is used for integration testing. It clones
all necessary repositories from master and run the integration test.
See pull request which is currently on the review:
singnet/platform-pipeline#4
The integration test allows to check that nothing is broken when one module
interacts with others.
|
Because the changes made by the pull-request are not merged, when the integration test is triggered, basically the triggered test is run without the changes introduced by the pr. As I understand it this is what is happening
|
Thank you. I see now.
I updated the fix to trigger the platform-pipeline integration test only if
the there is a merge into the master branch (case 2).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have added the environment variables.
The fix allows to trigger the platform-pipeline after the current build successful execution.
It requires that in the CircleCI dashboard:
Workflows -> platform-pipeline -> Settings -> API Permissions with necessary permissions.
Workflows -> snet-daemon-> Settings ->Environment Variables