Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger platform-pipeline build after successful execution #38

Merged
merged 2 commits into from
Sep 27, 2018
Merged

Trigger platform-pipeline build after successful execution #38

merged 2 commits into from
Sep 27, 2018

Conversation

stellarspot
Copy link
Contributor

@stellarspot stellarspot commented Sep 21, 2018

The fix allows to trigger the platform-pipeline after the current build successful execution.

It requires that in the CircleCI dashboard:

  1. A token with name CIRCLECI_PLATFORM_PIPELINE_TOKEN is created
    Workflows -> platform-pipeline -> Settings -> API Permissions with necessary permissions.
  2. The CIRCLECI_PLATFORM_PIPELINE_TOKEN env variable is added to the snet-daemon
    Workflows -> snet-daemon-> Settings ->Environment Variables

Copy link

@amebel amebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would one need to trigger a build on master in another repo for pull-requests?

@stellarspot
Copy link
Contributor Author

stellarspot commented Sep 24, 2018 via email

@amebel
Copy link

amebel commented Sep 26, 2018

Because the changes made by the pull-request are not merged, when the integration test is triggered, basically the triggered test is run without the changes introduced by the pr. As I understand it this is what is happening

  1. test pull-request changes -> trigger test on platform-pipeline using master and without changes included in the pull-request, basically a rerun of the tests.
  2. merge pull-request on pass of pull-request-change -> trigger test on platform-pipeline using newly introduced changes to master.

@stellarspot
Copy link
Contributor Author

stellarspot commented Sep 26, 2018 via email

@amebel amebel self-requested a review September 27, 2018 05:26
Copy link

@amebel amebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have added the environment variables.

@stellarspot stellarspot merged commit 0c690b1 into singnet:master Sep 27, 2018
@stellarspot stellarspot deleted the feature/circleci-trigger-platform-pipeline-build branch October 18, 2018 09:51
anandrgitnirman pushed a commit that referenced this pull request Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants