Merge pull request #50 from sitegeist/chore-uri-path-segment

CHORE: Restructure check for correct uri path segment
sitegeist · Sep 20, 2024 · 035b096 · 035b096
2 parents aad7d08 + fb83927
commit 035b096
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/Classes/ContentRepository/NodeTranslationService.php b/Classes/ContentRepository/NodeTranslationService.php
@@ -213,13 +213,13 @@ public function translateNode(NodeInterface $sourceNode, NodeInterface $targetNo
         }
 
         foreach ($properties as $propertyName => $propertyValue) {
-            if ($targetNode->getProperty($propertyName) != $propertyValue) {
-                $targetNode->setProperty($propertyName, $propertyValue);
+            // Make sure the uriPathSegment is valid
+            if ($propertyName === 'uriPathSegment' && !preg_match('/^[a-z0-9\-]+$/i', $propertyValue)) {
+                $propertyValue = $this->nodeUriPathSegmentGenerator->generateUriPathSegment(null, $propertyValue);
             }
 
-            // Make sure the uriPathSegment is valid
-            if ($targetNode->getProperty('uriPathSegment') && !preg_match('/^[a-z0-9\-]+$/i', $targetNode->getProperty('uriPathSegment'))) {
-                $targetNode->setProperty('uriPathSegment', $this->nodeUriPathSegmentGenerator->generateUriPathSegment(null, $targetNode->getProperty('uriPathSegment')));
+            if ($targetNode->getProperty($propertyName) != $propertyValue) {
+                $targetNode->setProperty($propertyName, $propertyValue);
             }
         }
     }