refactor: better handling of missing RESOURCE_ROOT

sitepark · Jun 14, 2024 · 2261f1f · 2261f1f
1 parent c6c62e3
commit 2261f1f
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/config/services.yaml b/config/services.yaml
@@ -1,6 +1,6 @@
 parameters:
-  atoolo_resource.resource_root: '%env(RESOURCE_ROOT)%'
-  atoolo_resource.resource_host: '%env(RESOURCE_HOST)%'
+  atoolo_resource.resource_root: '%env(default::string:RESOURCE_ROOT)%'
+  atoolo_resource.resource_host: '%env(default::string:RESOURCE_HOST)%'
 
 services:
 

diff --git a/src/SiteKitResourceChannelFactory.php b/src/SiteKitResourceChannelFactory.php
@@ -32,6 +32,11 @@ class SiteKitResourceChannelFactory implements ResourceChannelFactory
     public function __construct(
         private readonly string $baseDir
     ) {
+        if (empty($this->baseDir)) {
+            throw new RuntimeException(
+                'RESOURCE_ROOT not set'
+            );
+        }
     }
 
     public function create(): ResourceChannel

diff --git a/test/SiteKitResourceChannelFactoryTest.php b/test/SiteKitResourceChannelFactoryTest.php
@@ -99,4 +99,10 @@ public function testCreateWithInvalidContextPhp(): void
         $this->expectException(\RuntimeException::class);
         $factory->create();
     }
+
+    public function testEmptyBaseDIr(): void
+    {
+        $this->expectException(\RuntimeException::class);
+        new SiteKitResourceChannelFactory('');
+    }
 }