test: add tests for invalid states

sitepark · Jan 16, 2024 · d7c8ffd · d7c8ffd
1 parent e564d75
commit d7c8ffd
Show file tree

Hide file tree

Showing 5 changed files with 69 additions and 2 deletions.
diff --git a/src/Loader/SiteKitResourceHierarchyLoader.php b/src/Loader/SiteKitResourceHierarchyLoader.php
@@ -128,6 +128,14 @@ protected function getPrimaryParentLocation(Resource $resource): ?string
 
         $firstParent = null;
         foreach ($parentList as $parent) {
+            if (!is_array($parent)) {
+                throw new InvalidResourceException(
+                    $resource->getLocation(),
+                    'primary parent in ' .
+                    'base.trees.' . $this->treeName . '.parents ' .
+                    'is invalid'
+                );
+            }
             $firstParent ??= $parent;
             $isPrimary = $parent['isPrimary'] ?? false;
             if ($isPrimary === true) {
@@ -187,7 +195,15 @@ protected function getChildrenLocationList(Resource $resource): array
             return [];
         }
 
-        return array_map(function ($child) {
+        return array_map(function ($child) use ($resource) {
+            if (!is_array($child)) {
+                throw new InvalidResourceException(
+                    $resource->getLocation(),
+                    'children in ' .
+                    'base.trees.' . $this->treeName . '.children ' .
+                    'not an array'
+                );
+            }
             return $child['url'];
         }, $childrenList);
     }

diff --git a/test/DataBagTest.php b/test/DataBagTest.php
@@ -10,7 +10,6 @@
 #[CoversClass(DataBag::class)]
 class DataBagTest extends TestCase
 {
-
     public function testGet(): void
     {
         $resource = new DataBag(

diff --git a/test/Loader/SiteKitResourceHierarchyLoaderTest.php b/test/Loader/SiteKitResourceHierarchyLoaderTest.php
@@ -101,6 +101,14 @@ public function testLoadChildren(): void
         );
     }
 
+    public function testLoadChildrenWithInvalidData(): void
+    {
+        $this->expectException(InvalidResourceException::class);
+        $children = $this->hierarchyLoader->loadChildren(
+            '/childrenWithInvalidData.php'
+        );
+    }
+
     public function testLoadWithoutChildren(): void
     {
         $children = $this->hierarchyLoader->loadChildren('/c.php');
@@ -139,6 +147,12 @@ public function testLoadRootResourcePrimaryParentWithoutUrl(): void
         $this->hierarchyLoader->loadParent('/primaryParentWithoutUrl.php');
     }
 
+    public function testLoadRootResourcePrimaryParentWithInvalidData(): void
+    {
+        $this->expectException(InvalidResourceException::class);
+        $this->hierarchyLoader->loadParent('/primaryParentWithInvalidData.php');
+    }
+
     public function testLoadRootResourcePrimaryParentWithNonStringUrl(): void
     {
         $this->expectException(InvalidResourceException::class);

diff --git a/test/resources/Loader/SiteKitResourceHierarchyLoader/childrenWithInvalidData.php b/test/resources/Loader/SiteKitResourceHierarchyLoader/childrenWithInvalidData.php
@@ -0,0 +1,19 @@
+<?php
+
+return new \Atoolo\Resource\Resource(
+    '/primaryParentWithoutUrl.php',
+    'primaryParentWithoutUrl',
+    'primaryParentWithoutUrl',
+    '',
+    [
+        'base' => [
+            'trees' => [
+                'category' => [
+                    'children' => [
+                        'a' => 'invalid'
+                    ]
+                ]
+            ]
+        ]
+    ]
+);
diff --git a/test/resources/Loader/SiteKitResourceHierarchyLoader/primaryParentWithInvalidData.php b/test/resources/Loader/SiteKitResourceHierarchyLoader/primaryParentWithInvalidData.php
@@ -0,0 +1,19 @@
+<?php
+
+return new \Atoolo\Resource\Resource(
+    '/primaryParentWithoutUrl.php',
+    'primaryParentWithoutUrl',
+    'primaryParentWithoutUrl',
+    '',
+    [
+        'base' => [
+            'trees' => [
+                'category' => [
+                    'parents' => [
+                        'a' => 'invalid'
+                    ]
+                ]
+            ]
+        ]
+    ]
+);