Feature/resource channel #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-var-resoruce-base-locator
Co-authored-by: Mario Schäper <95750382+sitepark-schaeper@users.noreply.github.com>
There was a problem hiding this comment.
the lang, language and locale namings are very confusing to me. is it, that a lang/language is just "de" or "en" and a locale would be "de_DE"/"en_US"? or can they also include an encoding lik "en_EN.UTF-8"?
either way, I believe this should be cleaned up and made clear, as currently everything is just a string (some of which even default to '').
I've seen a couple of occurences of using "/" in paths - did you consider using DIRECTORY_SEPARATOR? I don't really know which one is better - This will probably never be executed on windows and even if, for file paths "/" should work too. Is there a specific reason you chose to do it this way?
Co-authored-by: Mario Schäper <95750382+sitepark-schaeper@users.noreply.github.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A resource channel is a closed area in which the IES publishes its pages. This can be a live or preview area, for example.
The
ResourceChannelis required to be able to read publication area-specific values. This can be the anchor of the publication area, for example.Multi-language support is also included in this pull request.